Skip to content

feat: Migrate sample and sample tests - Batch 5 of 5#15

Merged
dizcology merged 10 commits intosample-final-stagefrom
sample-staging-5
Nov 12, 2020
Merged

feat: Migrate sample and sample tests - Batch 5 of 5#15
dizcology merged 10 commits intosample-final-stagefrom
sample-staging-5

Conversation

@vinnysenthil
Copy link
Copy Markdown
Contributor

@vinnysenthil vinnysenthil commented Sep 25, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9 (Batch 5 of 5) 🦕

@vinnysenthil vinnysenthil requested review from a team and dizcology as code owners September 25, 2020 22:01
@vinnysenthil vinnysenthil requested review from tmatsuo and removed request for a team September 25, 2020 22:01
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@release-please release-please bot requested a review from a team as a code owner September 25, 2020 23:09
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2020
@vinnysenthil vinnysenthil changed the base branch from release-v0.2.0 to sample-final-stage September 30, 2020 23:44
@vinnysenthil vinnysenthil requested review from busunkim96 and removed request for tmatsuo October 1, 2020 02:08
busunkim96
busunkim96 reviewed Oct 1, 2020
View reviewed changes
@busunkim96 busunkim96 mentioned this pull request Oct 1, 2020
Closed
munkhuushmgl
munkhuushmgl reviewed Nov 6, 2020
View reviewed changes
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Nov 7, 2020 •
edited
Loading

Here is the summary of changes.

You added 12 region tags.

To update this comment, add snippet-bot:force-run label.

aribray and others added 2 commits November 9, 2020 18:21
@aribray @busunkim96
Update samples/list_model_evaluation_slices_sample.py
69dc17c 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@aribray
format PredictRequest
cf80a94
@dizcology dizcology merged commit b982be3 into sample-final-stage Nov 12, 2020
@aribray aribray mentioned this pull request Nov 12, 2020
Closed
@vinnysenthil vinnysenthil deleted the sample-staging-5 branch December 3, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@munkhuushmgl munkhuushmgl Awaiting requested review from munkhuushmgl

2 more reviewers

@aribray aribray aribray left review comments

@dizcology dizcology dizcology approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aribray aribray

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinnysenthil @dizcology @busunkim96 @munkhuushmgl @aribray