fix: Add compatibility with protobuf==5.x #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ea8426 to
39e4d33
Compare
39e4d33 to
62b37ee
Compare
259b2a4 to
19c487f
Compare
vchudnov-g
reviewed
Mar 19, 2024
Contributor
Author
|
The pre-release failure in https://github.com/googleapis/proto-plus-python/actions/runs/8758049270/job/24037997447 is captured in #444 |
Contributor
Author
|
@vchudnov-g @ohmayr PTAL |
vchudnov-g
reviewed
May 30, 2024
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
vchudnov-g
approved these changes
May 31, 2024
Contributor
vchudnov-g
left a comment
There was a problem hiding this comment.
Looks good. Left two minor comments, but I think we're good to go.,
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add
always_print_fields_with_no_presencefields toto_jsonandto_dictdocs: Deprecate field
including_default_value_fieldsinto_jsonandto_dictfix: Add compatibility with protobuf==5.x
fix: AttributeError module 'google._upb._message' has no attribute 'MessageMapContainer'
ci: Add support for pre-release sessions
ci: Add python 3.13 to testing matrix
ci: Resolve
RecursionError: maximum recursion depth exceeded while calling a Python objectwhen running testsEND_COMMIT_OVERRIDE
Fixes #425
Fixes #427
Fixes #431
Fixes #445
For compatibility with https://pypi.org/project/protobuf/5.26.0rc2/
See protocolbuffers/protobuf@2699579