Skip to content

fix: ensure enums are incomparable w other enum types #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Sep 29, 2021
Merged

fix: ensure enums are incomparable w other enum types #248

gcf-merge-on-green merged 2 commits into from
Sep 29, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 24, 2021

Fixes #247.

@tseaver tseaver requested a review from a team as a code owner September 24, 2021 15:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #248 (ad10936) into master (6a43682) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          862       921   +59     
  Branches       149       169   +20     
=========================================
+ Hits           862       921   +59
Impacted Files Coverage Δ
proto/modules.py 100.00% <ø> (ø)
proto/enums.py 100.00% <100.00%> (ø)
proto/marshal/collections/repeated.py 100.00% <100.00%> (ø)
proto/marshal/marshal.py 100.00% <100.00%> (ø)
proto/message.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7e537...ad10936. Read the comment docs.

software-dov
software-dov approved these changes Sep 29, 2021
View reviewed changes
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5927c14 into master Sep 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the 247-enums-incomparable-w-other-enum-types branch September 29, 2021 16:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
@tseaver tseaver mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@software-dov software-dov software-dov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'IntEnum' values from different types compare equal

2 participants

@tseaver @software-dov