Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: nullable ListValue and Struct fields#129

Merged
software-dov merged 3 commits intogoogleapis:masterfrom
software-dov:nullable-lists
Sep 21, 2020
Merged

feat: nullable ListValue and Struct fields#129
software-dov merged 3 commits intogoogleapis:masterfrom
software-dov:nullable-lists

Conversation

@software-dov
Copy link
Copy Markdown
Contributor

Assume a message type with a ListValue or Struct field.
If a message instance is created with no value passed in for that field,
the field is None when accessed via Python.

Assume a message type with a ListValue field.
If a message instance is created with no value passed in for the
ListValue field, the field is None when accessed via Python.
Assume a message type with a Struct field.
When a message instance is created with no value passed for the Struct
field, the field presents as None when accessed from Python.
@software-dov software-dov requested a review from a team as a code owner September 21, 2020 15:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2020

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          857       857           
  Branches       149       149           
=========================================
  Hits           857       857           
Impacted Files Coverage Δ
proto/marshal/rules/struct.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e3b83...aefa7a3. Read the comment docs.

@software-dov software-dov merged commit 25aa888 into googleapis:master Sep 21, 2020
@software-dov software-dov deleted the nullable-lists branch September 21, 2020 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants