This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: revert "feat: json serialization and deserialization support stringy enums"#116
Merged
software-dov merged 1 commit intomasterfrom Sep 3, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 856 811 -45
Branches 149 136 -13
=========================================
- Hits 856 811 -45
Continue to review full report at Codecov.
|
software-dov
approved these changes
Sep 3, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #112
Closes #115. This seems to be causing unit test failures in DLP, Firestore, and Asset (possibly more)