Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

refactor!: remove location path utility methods#402

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth
Closed

refactor!: remove location path utility methods#402
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Dec 10, 2019

This PR was generated using Autosynth. 🌈

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Cloning googleapis.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:a7f89dbac851b1daf372db435f555fcbd77551a66bfb6ea3a21457e616be156d
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/translate/v3beta1.
synthtool > Generated code into /tmpfs/tmp/tmp3kgqvr0x.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:a7f89dbac851b1daf372db435f555fcbd77551a66bfb6ea3a21457e616be156d
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/cloud/translate/v3.
synthtool > Generated code into /tmpfs/tmp/tmp0_27ljxq.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

> core-js@2.6.11 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/translate@5.1.1 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/translate@5.1.1 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p . && cp -r protos build/

npm notice created a lockfile as package-lock.json. You should commit this file.
added 636 packages from 910 contributors and audited 1985 packages in 18.035s
found 0 vulnerabilities

npm WARN npm npm does not support Node.js v12.13.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/translate@5.1.1 fix /tmpfs/src/git/autosynth/working_repo
> gts fix && eslint --fix '**/*.js'


/tmpfs/src/git/autosynth/working_repo/samples/automl/automlTranslationDataset.js
   27:26  error  "@google-cloud/automl" is not found  node/no-missing-require
   76:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  122:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  159:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  199:26  error  "@google-cloud/automl" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/automl/automlTranslationModel.js
   27:26  error  "@google-cloud/automl" is not found  node/no-missing-require
   82:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  124:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  187:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  222:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  252:26  error  "@google-cloud/automl" is not found  node/no-missing-require
  277:26  error  "@google-cloud/automl" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/automl/automlTranslationPredict.js
  33:26  error  "@google-cloud/automl" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/hybridGlossaries.js
  27:32  error  "@google-cloud/text-to-speech" is not found  node/no-missing-require
  28:29  error  "@google-cloud/translate" is not found       node/no-missing-require
  29:26  error  "@google-cloud/vision" is not found          node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/quickstart.js
  27:31  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/automlTranslation.test.js
  17:26  error  "chai" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/hybridGlossaries.test.js
  18:26  error  "chai" is not found                     node/no-missing-require
  19:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/quickstart.test.js
  17:26  error  "chai" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/translate.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:29  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_batch_translate_text.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require
  19:27  error  "@google-cloud/storage" is not found    node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_batch_translate_text_with_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require
  19:27  error  "@google-cloud/storage" is not found    node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_batch_translate_text_with_glossary_and_model.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require
  19:27  error  "@google-cloud/storage" is not found    node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_batch_translate_text_with_model.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require
  19:27  error  "@google-cloud/storage" is not found    node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_create_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_delete_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_detect_language.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_get_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_get_supported_languages.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_get_supported_languages_for_targets.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_list_codes.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_list_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_list_language_names.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_translate_text.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_translate_text_with_glossary.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_translate_text_with_glossary_and_model.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3/translate_translate_text_with_model.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_batch_translate_text_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require
  19:27  error  "@google-cloud/storage" is not found    node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_create_glossary_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_delete_glossary_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_detect_language_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_get_glossary_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_list_codes_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_list_glossary_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_list_language_names_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_translate_text_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_translate_text_with_glossary_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/test/v3beta1/translate_translate_text_with_model_beta.test.js
  17:26  error  "chai" is not found                     node/no-missing-require
  18:44  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/translate.js
   20:31  error  "@google-cloud/translate" is not found  node/no-missing-require
   49:31  error  "@google-cloud/translate" is not found  node/no-missing-require
   69:31  error  "@google-cloud/translate" is not found  node/no-missing-require
   94:31  error  "@google-cloud/translate" is not found  node/no-missing-require
  124:31  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_batch_translate_text.js
  33:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_batch_translate_text_with_glossary.js
  35:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_batch_translate_text_with_glossary_and_model.js
  37:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_batch_translate_text_with_model.js
  35:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_create_glossary.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_delete_glossary.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_detect_language.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_get_glossary.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_get_supported_languages.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_get_supported_languages_for_target.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_list_codes.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_list_glossary.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_list_language_names.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_translate_text.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_translate_text_with_glossary.js
  33:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_translate_text_with_glossary_and_model.js
  35:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3/translate_translate_text_with_model.js
  33:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_batch_translate_text_beta.js
  32:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_create_glossary_beta.js
  30:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_delete_glossary_beta.js
  30:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_detect_language_beta.js
  30:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_get_glossary_beta.js
  30:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_list_codes_beta.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_list_glossary_beta.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_list_language_names_beta.js
  26:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_translate_text_beta.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_translate_text_with_glossary_beta.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require

/tmpfs/src/git/autosynth/working_repo/samples/v3beta1/translate_translate_text_with_model_beta.js
  31:46  error  "@google-cloud/translate" is not found  node/no-missing-require
  32:26  error  "@google-cloud/automl" is not found     node/no-missing-require

✖ 118 problems (118 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/translate@5.1.1 fix: `gts fix && eslint --fix '**/*.js'`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/translate@5.1.1 fix script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2019-12-10T12_26_44_854Z-debug.log
installing semver@^5.5.0
installing minimist@^1.2.0
installing espree@^3.5.4
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@callmehiphop
Copy link
Contributor

callmehiphop commented Dec 10, 2019

@alexander-fenster @bcoe this is a breaking change, do we know if it is intentional?

@callmehiphop callmehiphop changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. refactor!: remove location path utility methods Dec 10, 2019
@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 10, 2019
@alexander-fenster
Copy link
Contributor

alexander-fenster commented Dec 10, 2019

@xiaozhenliu-gg5 Can you please take a look and see why Location path template was removed from the path templates list in the client constructor?

@xiaozhenliu-gg5
Copy link
Contributor

xiaozhenliu-gg5 commented Dec 10, 2019

Sure, I think we read google.api.resource instead of google.api.resource_definition for the resources, now it cannot recognize the common resource because of the name change.

@xiaozhenliu-gg5
Copy link
Contributor

xiaozhenliu-gg5 commented Dec 10, 2019

Also we take the messages and its options to parse in the resources, not the option directly, that is the cause for the breaking change.

@alexander-fenster I'm curious about the motivation for changing the structure and annotation for common resource file? Thanks

This was referenced Dec 10, 2019
Closed
Closed
@alexander-fenster
Copy link
Contributor

alexander-fenster commented Dec 10, 2019

Closing this, the next publish should be fine.

@alexander-fenster alexander-fenster deleted the autosynth branch December 10, 2019 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexander-fenster alexander-fenster

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshi-automation @callmehiphop @alexander-fenster @xiaozhenliu-gg5 @googlebot