fix(signed-url): replace encodeURIComponent with custom encoding function #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
+ Coverage 95.36% 95.39% +0.03%
==========================================
Files 11 11
Lines 1230 1239 +9
Branches 307 308 +1
==========================================
+ Hits 1173 1182 +9
Misses 29 29
Partials 28 28
Continue to review full report at Codecov.
|
55945ab to
a468029
Compare
Contributor
|
It makes me really uncomfortable to see custom non-standard encoding implementation. Where is the documentation that explains how the encoding should work? It should be mentioned in the code comment if it exists. |
frankyn
suggested changes
Oct 30, 2019
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Add a system test to confirm with GCS backend. Other than that LGTM.
alexander-fenster
approved these changes
Oct 30, 2019
bcoe
reviewed
Oct 31, 2019
alexander-fenster
approved these changes
Oct 31, 2019
frankyn
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859 🦕
Made changes to how signed URLs (v2 and v4) are url-encoded:
encodeURIComponentdoes not encode the following characters:! * ' ( ), which should have been encoded./in the object's (file) name should not have been encoded. (caused issue fix(deps): update dependency date-and-time to ^0.10.0 #857)