fix: file#move do not delete origin file if same as destination #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
=========================================
Coverage ? 95.29%
=========================================
Files ? 11
Lines ? 1212
Branches ? 303
=========================================
Hits ? 1155
Misses ? 29
Partials ? 28
Continue to review full report at Codecov.
|
Member
|
Sounds like what we really should do here is to error out when the user tries to copy/move to the same destination, unless I'm missing something here? |
Contributor
Author
|
IMHO I am not sure passing same destination on copy/move deserves an error (would be a breaking change). WDYT? |
Member
|
Yeah I would try to avoid a breaking change here as well. The draft looks good, promote it to a PR? |
4c9d057 to
7dacc3a
Compare
jkwlui
reviewed
Oct 7, 2019
stephenplusplus
approved these changes
Oct 7, 2019
jkwlui
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if user passes same
bucketobject,fileobject, orfileNamestring as the original file, the client will attempt to "copy" (essentially leaving the file in place) and subsequently delete the origin/destination file.