Skip to content

feat: allow setting standard Bucket storage class #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 2 commits into from
Oct 7, 2019
Merged

feat: allow setting standard Bucket storage class #873

stephenplusplus merged 2 commits into from
Oct 7, 2019

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Oct 3, 2019 •
edited
Loading

Fixes #847

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@stephenplusplus stephenplusplus requested review from JustinBeckwith, frankyn and jkwlui and removed request for JustinBeckwith October 3, 2019 14:00
@codecov
Copy link

codecov bot commented Oct 4, 2019 •
edited
Loading

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #873   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          11       11           
  Lines        1206     1206           
  Branches      300      300           
=======================================
  Hits         1149     1149           
  Misses         29       29           
  Partials       28       28
Impacted Files Coverage Δ
src/storage.ts 99.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ebface...486a85b. Read the comment docs.

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@stephenplusplus stephenplusplus merged commit 12a99e9 into googleapis:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frankyn frankyn frankyn approved these changes

@jkwlui jkwlui jkwlui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CreateBucketRequest should support standard storage class

5 participants

@stephenplusplus @frankyn @jkwlui @googlebot @kokoro-team