Skip to content

fix: create correct v4 signed url with cname #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkwlui merged 2 commits into from
Sep 30, 2019
Merged

fix: create correct v4 signed url with cname #868

jkwlui merged 2 commits into from
Sep 30, 2019

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Sep 30, 2019 •
edited
Loading

#859

This PR fixes the following:

  1. Fix host:[cname] instead of host:storage.googleapis.com when cname is provided when building canonical request.
  2. Use only the object's name in the request path when cname is used:
// Before
GET
/mycname.com/object_name

host:storage.googleapis.com

// After
GET
/object_name

host:mycname.com

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2019
@jkwlui jkwlui requested a review from frankyn September 30, 2019 21:07
@jkwlui jkwlui self-assigned this Sep 30, 2019
@codecov
Copy link

codecov bot commented Sep 30, 2019 •
edited
Loading

Codecov Report

Merging #868 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   95.26%   95.26%   +<.01%     
==========================================
  Files          11       11              
  Lines        1203     1205       +2     
  Branches      298      300       +2     
==========================================
+ Hits         1146     1148       +2     
  Misses         29       29              
  Partials       28       28
Impacted Files Coverage Δ
src/file.ts 98.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3351c7b...b9abb77. Read the comment docs.

@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2019
@jkwlui jkwlui merged commit ace3b5e into master Sep 30, 2019
@jkwlui jkwlui deleted the fix-v4-signed-url-cname branch October 1, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkwlui jkwlui

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkwlui @frankyn @googlebot @kokoro-team