Skip to content

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Aug 21, 2019

Starting from 10.0.3, @types/nock started using nock as default export,
even though the library uses module export. This broke our typescript
compilation.

Fixing the version of @types/nock to 10.0.0 fixed the problem.

TODO

  • Report issue at DefinitelyTyped.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2019
@jkwlui jkwlui closed this Aug 21, 2019
@jkwlui jkwlui deleted the fix-nock-types branch August 21, 2019 00:44
@jkwlui
Copy link
Member Author

jkwlui commented Aug 21, 2019

nope - this is not @types/nock

@jkwlui jkwlui mentioned this pull request Aug 21, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants