Skip to content

HMAC key: projectId option #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Aug 8, 2019
Merged

HMAC key: projectId option #801

stephenplusplus merged 3 commits into from
Aug 8, 2019

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Aug 7, 2019

No description provided.

@jkwlui jkwlui requested a review from frankyn August 7, 2019 00:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2019
@jkwlui jkwlui requested a review from stephenplusplus August 7, 2019 00:33
@jkwlui jkwlui self-assigned this Aug 7, 2019
frankyn
frankyn approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenplusplus stephenplusplus merged commit 941cb36 into hmac-sa-admin Aug 8, 2019
@stephenplusplus stephenplusplus deleted the hmac-sa-admin-project-id branch August 8, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkwlui jkwlui

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jkwlui @stephenplusplus @frankyn @googlebot