fix(typescript): make SetLabelOptions optional #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JesseLovelace as mentioned previously, no code change was required. So I've added some e2e tests to make sure the field was populated correctly. |
Contributor
JesseLovelace
left a comment
There was a problem hiding this comment.
Can you also update the documentation at 2755 to specify that multi_regional and regional are now legacy/deprecated?
JustinBeckwith
approved these changes
Jul 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 9 9
Lines 1132 1132
Branches 287 287
=======================================
Hits 1093 1093
Misses 11 11
Partials 28 28
Continue to review full report at Codecov.
|
callmehiphop
commented
Jul 15, 2019
bcoe
approved these changes
Jul 15, 2019
JesseLovelace
approved these changes
Jul 15, 2019
jkwlui
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(bucket): location type system tests
docs(bucket): add verbiage about deprecated storage classes
Closes #732