Skip to content

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Jun 20, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2019
@jkwlui jkwlui changed the title feat: HMAC CRUD methods feat: HMAC System tests Jun 20, 2019
@jkwlui jkwlui changed the base branch from master to hmac-sa-admin June 20, 2019 23:05
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 27, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #750 into hmac-sa-admin will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           hmac-sa-admin     #750      +/-   ##
=================================================
+ Coverage          95.14%   96.55%   +1.41%     
=================================================
  Files                 11        9       -2     
  Lines               1194     1132      -62     
  Branches             296      287       -9     
=================================================
- Hits                1136     1093      -43     
+ Misses                30       11      -19     
  Partials              28       28
Impacted Files Coverage Δ
src/storage.ts 97.36% <0%> (-0.85%) ⬇️
src/index.ts 100% <0%> (ø) ⬆️
src/bucket.ts 92.68% <0%> (ø) ⬆️
src/file.ts 98.12% <0%> (ø) ⬆️
src/hmacKey.ts
bin/benchwrapper.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b270054...4eda664. Read the comment docs.

@jkwlui jkwlui merged commit a4c4a66 into hmac-sa-admin Aug 13, 2019
@stephenplusplus stephenplusplus deleted the hmac-sa-admin-system-test branch November 26, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants