Skip to content

fix(types): fix signatures of listing methods #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JustinBeckwith merged 1 commit into from
May 7, 2019
Merged

fix(types): fix signatures of listing methods #703

JustinBeckwith merged 1 commit into from
May 7, 2019

Conversation

@AVaksman
Copy link
Contributor

@AVaksman AVaksman commented May 7, 2019

Fixes #672

  • Tests and linter pass

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2019
@AVaksman AVaksman marked this pull request as ready for review May 7, 2019 22:54
@JustinBeckwith JustinBeckwith changed the title types: - fix signatures of listing methods fix(types): fix signatures of listing methods May 7, 2019
@JustinBeckwith JustinBeckwith merged commit 42937a8 into googleapis:master May 7, 2019
@AVaksman AVaksman deleted the fix_signatures_ts branch May 8, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tuple type '[File[]]' with length '1' cannot be assigned to tuple with length '3'.

3 participants

@AVaksman @JustinBeckwith @googlebot