fix(ts): improve return types for response metadata #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
approved these changes
Apr 6, 2019
bcoe
left a comment
There was a problem hiding this comment.
this looks good to me Metadata reads much better than r.Response.
bcoe
reviewed
Apr 6, 2019
src/bucket.ts
Outdated
| export type GetBucketResponse = [Bucket, Metadata]; | ||
|
|
||
| export interface GetBucketCallback { | ||
| (err: ApiError|null, bucket: Bucket|null, |
There was a problem hiding this comment.
seems like the linting gods might be angry.
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 9 9
Lines 921 921
Branches 100 100
=======================================
Hits 903 903
Misses 9 9
Partials 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bonus, drops dependencies on
teeny-requestand@types/request