Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

build: make docs check not required#2623

Merged
ddelgrosso1 merged 1 commit intomainfrom
make-docs-optional
Jul 30, 2025
Merged

build: make docs check not required#2623
ddelgrosso1 merged 1 commit intomainfrom
make-docs-optional

Conversation

@ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested a review from a team July 30, 2025 15:34
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner July 30, 2025 15:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 30, 2025
@ddelgrosso1
Copy link
Contributor Author

Rationale: Github recently lowered the limits on requests coming from non-authenticated accounts. In turn our docs check is failing since it now gets rate limited. We may be able to re-enable this check once JustinBeckwith/linkinator#674 is merged and we are on a compatible version of Node.

@ddelgrosso1 ddelgrosso1 merged commit f6b68dc into main Jul 30, 2025
18 of 19 checks passed
@ddelgrosso1 ddelgrosso1 deleted the make-docs-optional branch July 30, 2025 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants