Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

build: resolve issue with build process#2619

Merged
ddelgrosso1 merged 6 commits intomainfrom
fix-build-issue
Aug 1, 2025
Merged

build: resolve issue with build process#2619
ddelgrosso1 merged 6 commits intomainfrom
fix-build-issue

Conversation

@thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2615

@thiyaguk09 thiyaguk09 requested a review from a team July 23, 2025 05:38
@thiyaguk09 thiyaguk09 requested a review from a team as a code owner July 23, 2025 05:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 23, 2025
@thiyaguk09 thiyaguk09 changed the title fix: build issue fix(build): resolve issue with build process Jul 23, 2025
@thiyaguk09 thiyaguk09 marked this pull request as draft July 23, 2025 11:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 30, 2025
@thiyaguk09 thiyaguk09 marked this pull request as ready for review July 30, 2025 14:20
@ddelgrosso1
Copy link
Contributor

Can you make this commit and PR title either build: or chore:. Labeling it as a fix will trigger a release which is not necessary.

@thiyaguk09 thiyaguk09 changed the title fix(build): resolve issue with build process build: resolve issue with build process Jul 31, 2025
@thiyaguk09
Copy link
Contributor Author

Can you make this commit and PR title either build: or chore:. Labeling it as a fix will trigger a release which is not necessary.

Understood. I will ensure all future commit and PR titles for changes that should not trigger a release are prefixed with either build: or chore:, as per your guidance.

@@ -1,5 +1,5 @@
/**
* Copyright 2024 Google LLC
* Copyright 2025 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't update the copyright dates. Ditto for the ones below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to the previous version; the change was made earlier due to a header-check error in commit 77070b5.

@thiyaguk09 thiyaguk09 requested a review from ddelgrosso1 August 1, 2025 07:57
@ddelgrosso1 ddelgrosso1 merged commit bcf58f0 into main Aug 1, 2025
20 of 21 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix-build-issue branch August 1, 2025 14:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The build failed

2 participants