This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: adds integration tests for Universe Domain configuration#2538
Merged
Conversation
…elds'-to-getFiles feat(storage): add support for 'fields' query parameter to getFiles
…elds'-to-getFiles build: fix path-to-regexp to older version due to node 14 requirement
…elds'-to-getFiles Remove unnecessary sample code
Node Transfer Manager: add support for 'skipIfExists' option for downloadMany
…any-in-transfer-manager
…dMany-in-transfer-manager feat(storage): add support for 'skipIfExists' option for downloadMany
…okoro feat: adds integration tests for Universe Domain configuration with kokoro changes
…-tests feat: adds integration tests for Universe Domain configuration
|
Warning: This pull request is touching the following templated files:
|
Contributor
|
Code looks good, think the |
Contributor
Author
The |
ddelgrosso1
reviewed
Oct 3, 2024
ddelgrosso1
approved these changes
Oct 3, 2024
ddelgrosso1
suggested changes
Oct 3, 2024
ddelgrosso1
left a comment
Contributor
There was a problem hiding this comment.
What happened to the kokoro changes? I saw them at one point.
ddelgrosso1
reviewed
Oct 3, 2024
Contributor
Author
gcf-owl-bot removed those changes 31ca744. |
ddelgrosso1
reviewed
Oct 4, 2024
ddelgrosso1
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes