This repository was archived by the owner on Mar 3, 2026. It is now read-only.
test: increase timeout of delay in hmac get test#2457
Merged
Conversation
ddelgrosso1
commented
May 6, 2024
| }); | ||
|
|
||
| it('should get metadata for an HMAC key', async function () { | ||
| this.retries(3); |
Contributor
Author
There was a problem hiding this comment.
This is no longer necessary as this.retries(3) is set at the outermost level.
danielduhh
reviewed
May 7, 2024
danielduhh
left a comment
Contributor
There was a problem hiding this comment.
Im guessing this issue exists in other languages. What are other folks doing to mitigate this?
Contributor
Author
|
@danielduhh added #2461 |
danielduhh
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2456 🦕