feat: support OLM Prefix/Suffix #1847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 6, 2022
…nodejs-storage into shaffeeullah/olmPrefixSuffix
ddelgrosso1
reviewed
Apr 6, 2022
system-test/storage.ts
Outdated
Comment on lines
1345
to
1346
| (rule.condition.matchesPrefix as string[]).length === 1 && | ||
| (rule.condition.matchesPrefix as string[])[0] === TESTS_PREFIX |
Contributor
There was a problem hiding this comment.
Optional: You can use Array.isArray here to avoid casting
ddelgrosso1
approved these changes
Apr 7, 2022
Contributor
|
Should this be marked do not merge until the feature is ready? |
…feeullah/olmPrefixSuffix
…nodejs-storage into shaffeeullah/olmPrefixSuffix
…nodejs-storage into shaffeeullah/olmPrefixSuffix
danielbankhead
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are not expected to pass until the feature is released.