Skip to content

test: fix precondition test #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shaffeeullah merged 4 commits into from
Jun 7, 2021
Merged

test: fix precondition test #1481

shaffeeullah merged 4 commits into from
Jun 7, 2021

Conversation

@tritone
Copy link
Contributor

@tritone tritone commented Jun 4, 2021

This test matches the exact error string from the service, which
has changed. Using the reason instead should be more robust.

Same as googleapis/java-storage#861

Fixes #1480

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@tritone
test: fix precondition test
7c3a067 
This test matches the exact error string from the service, which
has changed. Using the reason instead should be more robust.

Same as googleapis/java-storage#861

Fixes googleapis#1480
@tritone tritone requested a review from a team June 4, 2021 04:21
@tritone tritone requested a review from a team as a code owner June 4, 2021 04:21
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@tritone
Copy link
Contributor Author

tritone commented Jun 4, 2021

Going to pair with @shaffeeullah later today on getting this working correctly.

@tritone tritone marked this pull request as draft June 4, 2021 16:54
@tritone tritone marked this pull request as ready for review June 7, 2021 01:28
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2021
@shaffeeullah shaffeeullah merged commit 3cb4780 into googleapis:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage file generations: should throw an error Precondition Failed on overwrite with version 0, then save file with and without resumable failed

3 participants

@tritone @shaffeeullah @yoshi-kokoro