This repository was archived by the owner on Mar 3, 2026. It is now read-only.
fix: 🐛 fix the issue 2667, do not mutate object given to options …#2668
Merged
ddelgrosso1 merged 3 commits intogoogleapis:mainfrom Oct 29, 2025
Merged
fix: 🐛 fix the issue 2667, do not mutate object given to options …#2668ddelgrosso1 merged 3 commits intogoogleapis:mainfrom
ddelgrosso1 merged 3 commits intogoogleapis:mainfrom
Conversation
…ment in file download method
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
@gnekich thank you for the contribution! |
ddelgrosso1
approved these changes
Oct 29, 2025
eliekozah
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the issue #2667
Description
Instead of assigning argument passed to download to options doing Object.assing({}, options) before to copy the values.
Impact
Fixes bug.
Testing
It would be good to cover this with tests as it is trivial to test for this. So I added one for this method, and fixed one faulty one, that should have captured this before.
Checklist
Fixes #2667 🦕