Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: add function to allow user to set destination in transfer manager#2497

Merged
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
ddelgrosso1:tm-custom-dest
Jul 15, 2024
Merged

feat: add function to allow user to set destination in transfer manager#2497
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
ddelgrosso1:tm-custom-dest

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2492 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team July 9, 2024 14:45
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 9, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2024
@ddelgrosso1 ddelgrosso1 merged commit dc1e488 into googleapis:main Jul 15, 2024
@ddelgrosso1 ddelgrosso1 deleted the tm-custom-dest branch July 15, 2024 14:06
@release-please release-please Bot mentioned this pull request Jul 15, 2024
Merged
@FarrelBhagaskara FarrelBhagaskara mentioned this pull request Aug 7, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@abdoghazy2015 abdoghazy2015 mentioned this pull request Aug 29, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielduhh danielduhh danielduhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to set destination while using uploadManyFiles in TransferManager

2 participants

@ddelgrosso1 @danielduhh