Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: make CreateBucketRequest extend from BucketMetadata to allow all…#2489

Merged
ddelgrosso1 merged 3 commits into
googleapis:mainfrom
ddelgrosso1:fix-create-bucket-request
Jul 8, 2024
Merged

fix: make CreateBucketRequest extend from BucketMetadata to allow all…#2489
ddelgrosso1 merged 3 commits into
googleapis:mainfrom
ddelgrosso1:fix-create-bucket-request

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

… fields to be set

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2454 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team June 14, 2024 20:09
@ddelgrosso1

ddelgrosso1 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

Making CreateBucketReqest extend BucketMetadata so that the missing fields that are accepted by https://cloud.google.com/storage/docs/json_api/v1/buckets/insert get carried over. I've left the custom fields alone as that would be a breaking change.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2024
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jun 15, 2024
@ddelgrosso1 ddelgrosso1 added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 17, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 17, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
danielduhh
danielduhh reviewed Jun 26, 2024
View reviewed changes

@danielduhh danielduhh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

Comment thread src/storage.ts
projection?: 'full' | 'noAcl';
regional?: boolean;
requesterPays?: boolean;
retentionPolicy?: object;

@danielduhh danielduhh Jun 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will removing this cause any issues?

@ddelgrosso1 ddelgrosso1 Jun 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't removed. This interface now extends BucketMetadata

nodejs-storage/src/bucket.ts

Lines 347 to 351 in 18eef67

retentionPolicy?: {
effectiveTime?: string;
isLocked?: boolean;
retentionPeriod?: string | number;
} | null;

@ddelgrosso1

ddelgrosso1 commented Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

@danielduhh all tests are existing. Didn't make much sense to add unit tests to test each individual field is settable.

@ddelgrosso1 ddelgrosso1 force-pushed the fix-create-bucket-request branch from 64fc8d7 to 23d536c Compare June 26, 2024 13:25
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jun 26, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 26, 2024
@ddelgrosso1 ddelgrosso1 merged commit 013a5a4 into googleapis:main Jul 8, 2024
@ddelgrosso1 ddelgrosso1 deleted the fix-create-bucket-request branch July 8, 2024 23:49
@release-please release-please Bot mentioned this pull request Jul 8, 2024
Merged
@kazimanzurrashid kazimanzurrashid mentioned this pull request Aug 2, 2024
Open
@dizzylilly dizzylilly mentioned this pull request Aug 3, 2024
Open
@FarrelBhagaskara FarrelBhagaskara mentioned this pull request Aug 7, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@danielduhh danielduhh danielduhh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CreateBucketRequest type is misaligned with JSON API

2 participants

@ddelgrosso1 @danielduhh