Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

feat: allow setting contentEncoding during compose#2431

Merged
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
zuozp8:compose-contentEncoding
Apr 15, 2024
Merged

feat: allow setting contentEncoding during compose#2431
ddelgrosso1 merged 2 commits into
googleapis:mainfrom
zuozp8:compose-contentEncoding

Conversation

@zuozp8

@zuozp8 zuozp8 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

Fixes #2430

@zuozp8 zuozp8 requested review from a team March 26, 2024 12:21
@google-cla

google-cla Bot commented Mar 26, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 26, 2024
@zuozp8 zuozp8 force-pushed the compose-contentEncoding branch from 57a2d92 to 2d458db Compare March 26, 2024 12:30
@ddelgrosso1 ddelgrosso1 changed the title allow setting contentEncoding during compose feat: allow setting contentEncoding during compose Mar 26, 2024
@ddelgrosso1

Copy link
Copy Markdown
Contributor

Thanks for the contribution @zuozp8. It looks like the test

Bucket
       combine
         should make correct API request:

needs to be updated.

@zuozp8 zuozp8 force-pushed the compose-contentEncoding branch from 2d458db to 2f6c03c Compare March 26, 2024 14:56
@zuozp8

zuozp8 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

@ddelgrosso1 sure, I updated the test

I made sure my undefined doesn't look and caused content-type to be undefined too in that test

@zuozp8

zuozp8 commented Mar 26, 2024

Copy link
Copy Markdown
Contributor Author

@ddelgrosso1 linter wants to change files that I didn't touch, should i change them?

wouldn't it be better to commit package-lock.json into repo to avoid unexpected version bumps?

@ddelgrosso1

Copy link
Copy Markdown
Contributor

@zuozp8 don't worry about them, I have another PR open that will fix them. As a general rule, we don't normally commit package locks but sometimes this is the outcome 😆

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 26, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2024
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 26, 2024
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@ddelgrosso1

Copy link
Copy Markdown
Contributor

Thanks again for the contribution @zuozp8. I will get this merged / released after Cloud Next is over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

combining gzipped files

3 participants