This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
a6c5e25 to
e5c8e8c
Compare
e5c8e8c to
851f870
Compare
851f870 to
06c038e
Compare
dfb4bbf to
1311e66
Compare
1311e66 to
a6fffb6
Compare
a6fffb6 to
5392c8e
Compare
a69f292 to
3c2ca74
Compare
fe8f44b to
d7afebb
Compare
9d3268f to
26a3098
Compare
src/transaction.ts
Outdated
| } | ||
| }) | ||
| .on('error', err => { | ||
| .on('error', async err => { |
Contributor
There was a problem hiding this comment.
This is problematic. If you make "error" event handler async , then span might not get end properly. Remove async from here and do void this.begin()
src/transaction.ts
Outdated
| } | ||
| }) | ||
| .on('error', err => { | ||
| .on('error', async err => { |
src/session-pool.ts
Outdated
|
|
||
| this._inventory.sessions.splice(index, 1); | ||
| this._destroy(session); | ||
| this._destroy(session) |
Contributor
There was a problem hiding this comment.
could we use void here instead ?
| @@ -61,6 +62,8 @@ export class DatabaseAdminClient { | |||
| private _defaults: {[method: string]: gax.CallSettings}; | |||
| private _universeDomain: string; | |||
| private _servicePath: string; | |||
| private _log = logging.log('spanner'); | |||
Contributor
There was a problem hiding this comment.
Are these changes manual ?
surbhigarg92
approved these changes
Apr 17, 2025
sakthivelmanii
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to Migrate NodeJS Spanner Client Library to Node 18 version to ensure long term support.