Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

chore(spanner): regenerate proto files#2050

Merged
harshachinta merged 6 commits intogoogleapis:mainfrom
harshachinta:proto-files-regeneration-protoc
May 22, 2024
Merged

chore(spanner): regenerate proto files#2050
harshachinta merged 6 commits intogoogleapis:mainfrom
harshachinta:proto-files-regeneration-protoc

Conversation

@harshachinta
Copy link
Copy Markdown
Contributor

@harshachinta harshachinta commented May 21, 2024

Protobuf support for the javascript/typescript is limited in the open source environment and direct support with proto compiler (i.e. protoc) is not available the way it’s supported in other languages like Java, Python, Go etc.

In this sample we use https://github.com/protobufjs/protobuf.js/blob/master/cli/README.md to generate the js/ts files
Ref: https://docs.google.com/document/d/11yVrfnMNTn5gJM_M1j7vwfm3t2fYAdYU8_WGR6oYPzw/edit?tab=t.0#bookmark=id.3qemojtrt4ut

@harshachinta harshachinta requested review from a team May 21, 2024 14:23
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels May 21, 2024
@harshachinta harshachinta requested a review from surbhigarg92 May 22, 2024 05:23
@harshachinta harshachinta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 22, 2024
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@harshachinta harshachinta merged commit 628f4b0 into googleapis:main May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants