This repository was archived by the owner on Mar 4, 2026. It is now read-only.
chore: Skip archived test#2018
Merged
gcf-merge-on-green[bot] merged 9 commits intogoogleapis:mainfrom Mar 8, 2024
Merged
Conversation
32c721b to
a8654b9
Compare
harshachinta
approved these changes
Mar 8, 2024
Contributor
harshachinta
left a comment
There was a problem hiding this comment.
LGTM, but can we make sure we have a plan to run these archived samples in some way? We could otherwise not detect issues with those samples.
Few thoughts on doing this,
- Run the archived samples in continuous and nightly builds thus leaving out presubmits.
- Run active and archived samples in presubmit only when there are changes in samples directory.
There could be some other better strategy but having this would help us find any regressions in archived samples.
|
Warning: This pull request is touching the following templated files:
|
harshachinta
approved these changes
Mar 8, 2024
Contributor
Author
Added the change to make sure we are running archived tests in continuous and nightly builds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.