Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

build: update gapic-generator-typescript to v4.4.1#1975

Merged
harshachinta merged 7 commits intomainfrom
owl-bot-copy
Feb 7, 2024
Merged

build: update gapic-generator-typescript to v4.4.1#1975
harshachinta merged 7 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 2, 2024 •
edited by harshachinta
Loading

  • Regenerate this pull request now.

PiperOrigin-RevId: 604765466

Source-Link: googleapis/googleapis@40203ca

Source-Link: https://github.com/googleapis/googleapis-gen/commit/07b7f3dad8aa1912d4acdcfd6365bb4236e4b54b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDdiN2YzZGFkOGFhMTkxMmQ0YWNkY2ZkNjM2NWJiNDIzNmU0YjU0YiJ9

BEGIN_NESTED_COMMIT
feat: Trusted Private Cloud support, use the universeDomain parameter
feat: auto populate UUID fields where needed
fix: revert changes to streaming retries

Use gapic-generator-typescript v4.4.0.

PiperOrigin-RevId: 603757799

Source-Link: googleapis/googleapis@1a45bf7

Source-Link: https://github.com/googleapis/googleapis-gen/commit/19ca4b45a53d00cb7bdd94b442b60bd237dfe123
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTljYTRiNDVhNTNkMDBjYjdiZGQ5NGI0NDJiNjBiZDIzN2RmZTEyMyJ9

docs: update the comment regarding eligible SQL shapes for PartitionQuery

PiperOrigin-RevId: 602806739

Source-Link: googleapis/googleapis@20b095b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/fc8a8ea3029c590d27fcbf36ad31ef7a822f40f4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmM4YThlYTMwMjljNTkwZDI3ZmNiZjM2YWQzMWVmN2E4MjJmNDBmNCJ9

feat: add FLOAT32 enum to TypeCode

PiperOrigin-RevId: 601176446

Source-Link: googleapis/googleapis@584ecd4

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0bdb815779d0fd7824bafff0c91046a7dca5cd5f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGJkYjgxNTc3OWQwZmQ3ODI0YmFmZmYwYzkxMDQ2YTdkY2E1Y2Q1ZiJ9

feat(spanner): add proto descriptors for proto and enum types in create/update/get database ddl requests

PiperOrigin-RevId: 601013501

Source-Link: googleapis/googleapis@81b24a5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/46f0446037906f0d905365835f02a652241f3de3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZmMDQ0NjAzNzkwNmYwZDkwNTM2NTgzNWYwMmE2NTIyNDFmM2RlMyJ9

fix: improve retry logic for streaming API calls
build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: https://github.com/googleapis/googleapis-gen/commit/da13d8222d3ba33734501999864458640f1405ae
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9

feat: add max_commit_delay API

PiperOrigin-RevId: 599315735

Source-Link: googleapis/googleapis@465a103

Source-Link: https://github.com/googleapis/googleapis-gen/commit/930e2318acbd10fb54d8668d2f2cf19fe413d5a9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwZTIzMThhY2JkMTBmYjU0ZDg2NjhkMmYyY2YxOWZlNDEzZDVhOSJ9

feat(spanner): add proto and enum types

PiperOrigin-RevId: 599046867

Source-Link: googleapis/googleapis@64a5bfe

Source-Link: https://github.com/googleapis/googleapis-gen/commit/6e96ab8bb1ec4536c5a0c4d095f53ce0578cb8a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmU5NmFiOGJiMWVjNDUzNmM1YTBjNGQwOTVmNTNjZTA1NzhjYjhhNCJ9

fix: correct long audio synthesis HTTP binding
docs: Deprecate the custom voice usage field

PiperOrigin-RevId: 595119987

Source-Link: googleapis/googleapis@c22f408

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4e9ca63d2cc7933eb7c383ce8b794fce152ea2fc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGU5Y2E2M2QyY2M3OTMzZWI3YzM4M2NlOGI3OTRmY2UxNTJlYTJmYyJ9
END_NESTED_COMMIT

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 2, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 2, 2024 19:03
@gcf-owl-bot gcf-owl-bot bot requested review from a team January 2, 2024 19:03
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 2, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xl Pull request size is extra large. labels Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2024
@gcf-owl-bot gcf-owl-bot bot changed the title fix: correct long audio synthesis HTTP binding feat(spanner): add proto and enum types Jan 17, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 17, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: s Pull request size is small. labels Jan 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@product-auto-label product-auto-label bot removed the size: xl Pull request size is extra large. label Jan 17, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 19, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Jan 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2024
@alexander-fenster alexander-fenster self-assigned this Jan 19, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2024
@alexander-fenster
Copy link
Copy Markdown
Contributor

alexander-fenster commented Jan 24, 2024

Just an update, I'm debugging the failing tests here.

@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Jan 30, 2024 •
edited
Loading

@alexander-fenster
Do we have an update on the failing tests? We need to merge the PR this week for having the proto changes for development.
Can you please take a look?

@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Feb 2, 2024 •
edited
Loading

@alexander-fenster @danieljbruce
We are blocked on this PR for a SPR item launch next week. Can you please help fix the builds by today?

@alexander-fenster
Copy link
Copy Markdown
Contributor

alexander-fenster commented Feb 2, 2024 •
edited
Loading

The following commit googleapis/googleapis@1a45bf7 should fix it as long as owlbot refreshes this branch.

@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Feb 3, 2024

@alexander-fenster Looks like it didn't work. The builds are still failing.

@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot bot commented Feb 5, 2024

Owl bot is regenerating pull request 1975...
Build name: MTEzZDBiZmEtY2RmYS00MTkzLWI1ODYtY2Y4Zjk0ZGU3NWZk

@gcf-owl-bot
feat: Trusted Private Cloud support, use the universeDomain parameter
a361861 
feat: auto populate UUID fields where needed
fix: revert changes to streaming retries

Use gapic-generator-typescript v4.4.0.

PiperOrigin-RevId: 603757799

Source-Link: googleapis/googleapis@1a45bf7

Source-Link: googleapis/googleapis-gen@19ca4b4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTljYTRiNDVhNTNkMDBjYjdiZGQ5NGI0NDJiNjBiZDIzN2RmZTEyMyJ9

docs: update the comment regarding eligible SQL shapes for PartitionQuery

PiperOrigin-RevId: 602806739

Source-Link: googleapis/googleapis@20b095b

Source-Link: googleapis/googleapis-gen@fc8a8ea
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmM4YThlYTMwMjljNTkwZDI3ZmNiZjM2YWQzMWVmN2E4MjJmNDBmNCJ9

feat: add FLOAT32 enum to TypeCode

PiperOrigin-RevId: 601176446

Source-Link: googleapis/googleapis@584ecd4

Source-Link: googleapis/googleapis-gen@0bdb815
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGJkYjgxNTc3OWQwZmQ3ODI0YmFmZmYwYzkxMDQ2YTdkY2E1Y2Q1ZiJ9

feat(spanner): add proto descriptors for proto and enum types in create/update/get database ddl requests

PiperOrigin-RevId: 601013501

Source-Link: googleapis/googleapis@81b24a5

Source-Link: googleapis/googleapis-gen@46f0446
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZmMDQ0NjAzNzkwNmYwZDkwNTM2NTgzNWYwMmE2NTIyNDFmM2RlMyJ9

fix: improve retry logic for streaming API calls
build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: googleapis/googleapis-gen@da13d82
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9

feat: add max_commit_delay API

PiperOrigin-RevId: 599315735

Source-Link: googleapis/googleapis@465a103

Source-Link: googleapis/googleapis-gen@930e231
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwZTIzMThhY2JkMTBmYjU0ZDg2NjhkMmYyY2YxOWZlNDEzZDVhOSJ9

feat(spanner): add proto and enum types

PiperOrigin-RevId: 599046867

Source-Link: googleapis/googleapis@64a5bfe

Source-Link: googleapis/googleapis-gen@6e96ab8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmU5NmFiOGJiMWVjNDUzNmM1YTBjNGQwOTVmNTNjZTA1NzhjYjhhNCJ9

fix: correct long audio synthesis HTTP binding
docs: Deprecate the custom voice usage field

PiperOrigin-RevId: 595119987

Source-Link: googleapis/googleapis@c22f408

Source-Link: googleapis/googleapis-gen@4e9ca63
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGU5Y2E2M2QyY2M3OTMzZWI3YzM4M2NlOGI3OTRmY2UxNTJlYTJmYyJ9
@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Feb 5, 2024

@alexander-fenster
The header and lint presubmits are still failing. Can you please take a look?

@alexander-fenster
Copy link
Copy Markdown
Contributor

alexander-fenster commented Feb 6, 2024

It's all green now!

@harshachinta
Copy link
Copy Markdown
Contributor

harshachinta commented Feb 7, 2024

Thanks @alexander-fenster

@gcf-owl-bot
Copy link
Copy Markdown
Contributor Author

gcf-owl-bot bot commented Feb 22, 2024

Owl bot is regenerating pull request 1975...
Build name: Mzg1ZWE0MGUtZTYzZC00Yjg2LWFiMGMtZGZiYWUzYTFkMGYx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danieljbruce danieljbruce danieljbruce approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexander-fenster alexander-fenster

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. owl-bot-copy size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexander-fenster @harshachinta @danieljbruce @surbhigarg92 @yoshi-kokoro