Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

docs: Update SessionPoolOptions typings using current defaults#1844

Merged
surbhigarg92 merged 3 commits intogoogleapis:mainfrom
nickcampbell18:main
May 17, 2023
Merged

docs: Update SessionPoolOptions typings using current defaults#1844
surbhigarg92 merged 3 commits intogoogleapis:mainfrom
nickcampbell18:main

Conversation

@nickcampbell18
Copy link
Copy Markdown
Contributor

The existing typings were incorrect - for example, there is no default limit on concurrent requests.

@nickcampbell18 nickcampbell18 requested review from a team May 9, 2023 12:36
@google-cla
Copy link
Copy Markdown

google-cla bot commented May 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented May 9, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels May 9, 2023
The existing typings were incorrect - for example, there is no default
limit on concurrent requests.
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 12, 2023
@surbhigarg92 surbhigarg92 changed the title Update SessionPoolOptions typings using current defaults docs: Update SessionPoolOptions typings using current defaults May 12, 2023
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2023
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@surbhigarg92 surbhigarg92 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2023
@surbhigarg92 surbhigarg92 merged commit 72efb81 into googleapis:main May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants