This repository was archived by the owner on Mar 4, 2026. It is now read-only.
test: emit empty metadata before emitting unspecified error#1801
Merged
surbhigarg92 merged 2 commits intomainfrom Feb 10, 2023
Merged
test: emit empty metadata before emitting unspecified error#1801surbhigarg92 merged 2 commits intomainfrom
surbhigarg92 merged 2 commits intomainfrom
Conversation
surbhigarg92
reviewed
Feb 9, 2023
surbhigarg92
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gRPC upgrade to
@grpc/grpc-jsv1.8.x, the server can emit errors without sending a metadata. It breaks some retrying logic inretry-request. This is unlikely to happen in production; for the test, let's make our stub gRPC server emitmetadataevent (with an emptyMetadatainstance) before emitting an error.BEGIN_COMMIT_OVERRIDE
fix: tests emit empty metadata before emitting unspecified error
END_COMMIT_OVERRIDE