This repository was archived by the owner on Mar 4, 2026. It is now read-only.
samples: DML with returning support#1759
Merged
gcf-merge-on-green[bot] merged 12 commits intogoogleapis:mainfrom Dec 22, 2022
Merged
samples: DML with returning support#1759gcf-merge-on-green[bot] merged 12 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 12 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
rajatbhatta
reviewed
Dec 20, 2022
Contributor
There was a problem hiding this comment.
@surbhigarg92: A general comment on the PR: Can we have same print statements across clients for consistency in samples? You can refer to https://github.com/googleapis/java-spanner/pull/2007/files.
asthamohta
approved these changes
Dec 21, 2022
Contributor
Author
|
@rajatbhatta This is as per the standards in NodeJS library, samples are consistent with other samples in the library. |
rajatbhatta
approved these changes
Dec 21, 2022
Contributor
rajatbhatta
left a comment
There was a problem hiding this comment.
LGTM, apart from a minor NIT.
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
|
Warning: This pull request is touching the following templated files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.