Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

samples: update datatypes to use Spanner.float()#1482

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
asthamohta:float-samples
Oct 5, 2021
Merged

samples: update datatypes to use Spanner.float()#1482
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
asthamohta:float-samples

Conversation

@asthamohta
Copy link
Copy Markdown
Contributor

@asthamohta asthamohta commented Sep 22, 2021

No description provided.

@asthamohta asthamohta requested review from a team September 22, 2021 09:30
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Sep 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2021
@asthamohta asthamohta requested a review from skuruppu September 22, 2021 09:31
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 22, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 22, 2021
@skuruppu skuruppu changed the title fix: Change in Samples on how to handle passing FLOAT64 samples: update datatypes to use Spanner.float() Sep 23, 2021
@asthamohta asthamohta force-pushed the float-samples branch 2 times, most recently from 3ef3211 to 75d35cf Compare September 23, 2021 05:30
@skuruppu skuruppu added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 23, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 23, 2021
@skuruppu skuruppu added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Oct 5, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2021
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit b203233 into googleapis:main Oct 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2021
@asthamohta asthamohta mentioned this pull request Oct 5, 2021
Closed
@asthamohta asthamohta deleted the float-samples branch January 4, 2022 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asthamohta @skuruppu @yoshi-kokoro