@hengfengli

@nielm The conventionalcommits check fails. I think the commit message needs to follow a convention.

@nielm The conventionalcommits check fails. I think the commit message needs to follow a convention.

fixed

Codecov Report

Merging #1370 (fcc54a7) into master (ecaaf3b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #1370    +/-   ##
========================================
  Coverage   98.60%   98.60%            
========================================
  Files          23       23            
  Lines       21950    21964    +14     
  Branches     1238     1112   -126     
========================================
+ Hits        21644    21658    +14     
  Misses        297      297            
  Partials        9        9            

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecaaf3b...fcc54a7. Read the comment docs.

Any idea what causes the check failures and what I can do to fix them?

@stephenplusplus Hi Stephen, do you have any idea why the lint fails? This PR doesn't touch backup.ts at all.

@bcoe did we change lint settings? There are so many lint failures that didn't exist before.

@skuruppu the library we rely on for linting changed these rules in a minor version, so we'll need to update and run --fix locally.

@bcoe It's strange. I ran npm run lint and npm run fix locally. I got no errors. But the lint CI check fails. Do you have any idea why this is happening?

I got the output:

> @google-cloud/spanner@5.7.0 lint
> gts check

version: 15

The version is different from the CI check (version: 14). Is this an issue?

@nielm I think I know what the issue is. I've had the same trouble for a long time as well.

When we run npm run fix locally, it makes a whole of of lint changes that are not compatible with the settings on GithubActions. So I usually run the command and revert all changes that are not related to the code I touched. It's a pain but will help you get this merged.

@skuruppu The issue is that even with the original 1-line change (without any lint fixes), the lint check fails as well. That's why @bcoe suggested to run npm run fix.

@skuruppu @hengfengli I think we should create separate PR to fix the lint. I will create it shortly.

Since a PR #1371 to fix all doc issues has been created, I think this PR can be closed.