Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: prevent unhandled promise rejection while projectId or credential not found#1340

Merged
skuruppu merged 3 commits intogoogleapis:masterfrom
laljikanjareeya:handle-error-project-credential
Apr 19, 2021
Merged

fix: prevent unhandled promise rejection while projectId or credential not found#1340
skuruppu merged 3 commits intogoogleapis:masterfrom
laljikanjareeya:handle-error-project-credential

Conversation

@laljikanjareeya
Copy link
Copy Markdown
Contributor

@laljikanjareeya laljikanjareeya commented Apr 9, 2021

Fixes #1333

@laljikanjareeya laljikanjareeya requested review from a team April 9, 2021 08:41
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Apr 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2021
olavloite
olavloite approved these changes Apr 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, but it seems that the CI environment is broken at the moment. There's a lot of (I think) unrelated build errors at the moment. I assume that the tests are green locally(?)

@laljikanjareeya
Copy link
Copy Markdown
Contributor Author

laljikanjareeya commented Apr 12, 2021

This seems good to me, but it seems that the CI environment is broken at the moment. There's a lot of (I think) unrelated build errors at the moment. I assume that the tests are green locally(?)

Yes All the tests are green locally.

@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #1340 (5af4e96) into master (7a1cd0c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1340    +/-   ##
========================================
  Coverage   98.60%   98.60%            
========================================
  Files          23       23            
  Lines       21960    21992    +32     
  Branches     1109     1238   +129     
========================================
+ Hits        21654    21686    +32     
  Misses        297      297            
  Partials        9        9
Impacted Files Coverage Δ
src/session-pool.ts 99.83% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1cd0c...5af4e96. Read the comment docs.

@skuruppu skuruppu merged commit 47ce076 into googleapis:master Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@olavloite olavloite olavloite approved these changes

@AVaksman AVaksman AVaksman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

prevent unhandled promise rejection while default credentials and projectId not set

5 participants

@laljikanjareeya @olavloite @AVaksman @skuruppu @yoshi-kokoro