This repository was archived by the owner on Mar 4, 2026. It is now read-only.
fix: do not create sessions after getDatabases call#1228
Merged
olavloite merged 8 commits intogoogleapis:masterfrom Oct 2, 2020
Merged
fix: do not create sessions after getDatabases call#1228olavloite merged 8 commits intogoogleapis:masterfrom
olavloite merged 8 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 23 23
Lines 21426 21426
Branches 1251 1251
=======================================
Hits 21126 21126
Misses 297 297
Partials 3 3
Continue to review full report at Codecov.
|
stephenplusplus
suggested changes
Aug 31, 2020
skuruppu
approved these changes
Sep 1, 2020
AVaksman
approved these changes
Sep 7, 2020
Contributor
Author
|
@stephenplusplus Friendly ping on this PR. Would you mind taking another look? Your request for change is currently blocking merging this. |
Contributor
|
@stephenplusplus friendly ping again. If you could take another look, that would be awesome. |
stephenplusplus
approved these changes
Oct 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
instance.getDatabases()would return a list ofDatabaseinstances. Each of these databases would be initialized with a default session pool containing a minimum of 25 sessions, potentially creating a lot of sessions unintentionally.Fixes #1227