Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

test: change system-test setup against emulator#1171

Merged
skuruppu merged 3 commits into
googleapis:masterfrom
skuruppu:cleanup-emulator-github-action
Jul 7, 2020
Merged

test: change system-test setup against emulator#1171
skuruppu merged 3 commits into
googleapis:masterfrom
skuruppu:cleanup-emulator-github-action

Conversation

@skuruppu

@skuruppu skuruppu commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

Use Docker image instead of manually downloading the emulator binary and running it.

@skuruppu skuruppu requested review from a team July 7, 2020 02:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
Use Docker image instead of manually downloading the emulator binary and
running it.
@skuruppu skuruppu force-pushed the cleanup-emulator-github-action branch from 0b39a97 to b506cfb Compare July 7, 2020 02:10
@codecov

codecov Bot commented Jul 7, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1171   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          23       23           
  Lines       20996    20996           
  Branches     1153     1153           
=======================================
  Hits        20627    20627           
  Misses        366      366           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782c76a...6e4b156. Read the comment docs.

@JustinBeckwith JustinBeckwith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better than a shell script and it makes me so happy 🤗

Comment thread .github/workflows/system-tests-against-emulator.yaml Outdated
@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020
@skuruppu skuruppu merged commit 66262e0 into googleapis:master Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants