Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Adding sample for pre-split feature#2274

Merged
surbhigarg92 merged 19 commits intogoogleapis:mainfrom
aksharauke:spilts
Apr 15, 2025
Merged

feat: Adding sample for pre-split feature#2274
surbhigarg92 merged 19 commits intogoogleapis:mainfrom
aksharauke:spilts

Conversation

@aksharauke
Copy link
Copy Markdown
Contributor

@aksharauke aksharauke commented Apr 4, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Description

Please provide a detailed description for the change.
As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.

Impact

What's the impact of this change?

Testing

Have you added unit and integration tests if necessary?
Were any tests changed? Are any breaking changes necessary?

Additional Information

Any additional details that we should be aware of?

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #issue_number_goes_here 🦕

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Apr 4, 2025
@aksharauke aksharauke marked this pull request as ready for review April 9, 2025 08:52
@aksharauke aksharauke requested review from a team April 9, 2025 08:52
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 9, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

surbhigarg92
surbhigarg92 reviewed Apr 10, 2025
View reviewed changes
Comment thread samples/system-test/spanner.test.js Outdated
Comment thread samples/database-add-split-points.js
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Apr 10, 2025

Warning: This pull request is touching the following templated files:

@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2025
surbhigarg92
surbhigarg92 reviewed Apr 11, 2025
View reviewed changes
Comment thread samples/system-test/spanner.test.js
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Apr 12, 2025

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 12, 2025
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 14, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Apr 15, 2025

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2025
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 15, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 15, 2025
@surbhigarg92 surbhigarg92 merged commit 3d5f080 into googleapis:main Apr 15, 2025
19 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2025
@release-please release-please Bot mentioned this pull request Apr 15, 2025
Merged
@aksharauke aksharauke deleted the spilts branch May 21, 2025 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@alkatrivedi alkatrivedi alkatrivedi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aksharauke @surbhigarg92 @alkatrivedi @yoshi-kokoro