feat(spanner): support for Multiplexed Session Partitioned Ops #2252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d5da0b to
f163bb1
Compare
This PR contains code changes to add support for option IsolationLevel at the client level and at the transaction level. supported methods are(RW and Blind Write): ``` - writeAtLeastOnce - runTransactionAsync - runTransaction - getTransaction - async getTransaction(from transaction runner class) ```
d16e367 to
433a20a
Compare
4803966 to
32ccb88
Compare
32ccb88 to
0176e8f
Compare
a0e46ff to
0683469
Compare
src/session-factory.ts
Outdated
| ? (this.isMultiplexed = true) | ||
| : (this.isMultiplexed = false); | ||
| // set the isMultiplexedPartitionedOps property to true if multiplexed session is enabled for paritioned ops, otherwise set the property to false | ||
| process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS === 'true' && |
Contributor
There was a problem hiding this comment.
isMultiplexedPartitionOps = process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS === 'true' && process.env.GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS === 'true'
0683469 to
312504c
Compare
src/session-factory.ts
Outdated
| * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return | ||
| * either a multiplexed session or a regular session based on the configuration. | ||
| * | ||
| * If the multiplexed sessions are not enabled, a session is retrieved from the regular session pool. |
Contributor
There was a problem hiding this comment.
Suggested change
| * If the multiplexed sessions are not enabled, a session is retrieved from the regular session pool. | |
| * If the multiplexed sessions are disabled, a session is retrieved from the regular session pool. |
src/session-factory.ts
Outdated
|
|
||
| /** | ||
| * Retrieves a session for partitioned operations, selecting the appropriate session type | ||
| * based on whether multiplexed sessions are enabled for partitioned operations. |
Contributor
There was a problem hiding this comment.
Suggested change
| * based on whether multiplexed sessions are enabled for partitioned operations. | |
| * based on whether multiplexed sessions are enabled. |
src/session-factory.ts
Outdated
| * Retrieves a session for partitioned operations, selecting the appropriate session type | ||
| * based on whether multiplexed sessions are enabled for partitioned operations. | ||
| * | ||
| * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return |
Contributor
There was a problem hiding this comment.
Suggested change
| * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which will return | |
| * If multiplexed sessions are enabled for partitioned ops this methods delegates the request to `getSession()`, which returns |
src/session-factory.ts
Outdated
| */ | ||
| release(session: Session): void { | ||
| if (!this.isMultiplexed) { | ||
| if (!session.metadata.multiplexed) { |
Contributor
There was a problem hiding this comment.
do we need optional check for "metadata" here ?
Contributor
Author
There was a problem hiding this comment.
made it optional
| }); | ||
| muxEnabled.forEach(isMuxEnabled => { | ||
| describe( | ||
| 'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS is ' + |
Contributor
There was a problem hiding this comment.
Suggested change
| 'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS is ' + | |
| 'when GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS is ' + |
test/mockserver/mockspanner.ts
Outdated
| * @param database The database to create the session for. | ||
| */ | ||
| private newSession(database: string): protobuf.Session { | ||
| private newSession(multiplexed: boolean, database: string): protobuf.Session { |
Contributor
There was a problem hiding this comment.
add multiplexed: boolean as an optional parameter, with default value as false
test/mockserver/mockspanner.ts
Outdated
| this.simulateExecutionTime(this.batchCreateSessions.name) | ||
| .then(() => { | ||
| const sessions = new Array<protobuf.Session>(); | ||
| const multiplexed = false; |
Contributor
There was a problem hiding this comment.
This change should not be required once you make multiplexed as optional
Contributor
Author
There was a problem hiding this comment.
yeah, updated. thanks for the suggestion!
312504c to
1014985
Compare
surbhigarg92
approved these changes
Mar 26, 2025
1014985 to
d26c69a
Compare
alkatrivedi
added a commit
that referenced
this pull request
Apr 14, 2025
* feat(spanner): support for Multiplexed Session Partitioned Ops * feat(spanner): add support for snapshot isolation (#2245) This PR contains code changes to add support for option IsolationLevel at the client level and at the transaction level. supported methods are(RW and Blind Write): ``` - writeAtLeastOnce - runTransactionAsync - runTransaction - getTransaction - async getTransaction(from transaction runner class) ``` * refactor * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains code changes to add support for multiplexed session support in Partitioned DML transactions.