Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: Add support for Interval#2192

Merged
surbhigarg92 merged 7 commits intogoogleapis:mainfrom
sagarwaal:interval_support
Apr 3, 2025
Merged

feat: Add support for Interval#2192
surbhigarg92 merged 7 commits intogoogleapis:mainfrom
sagarwaal:interval_support

Conversation

@sagarwaal
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sagarwaal sagarwaal requested review from a team November 15, 2024 08:58
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Nov 15, 2024
@sagarwaal sagarwaal requested a review from a team March 26, 2025 07:44
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 26, 2025
@olavloite olavloite changed the title Feat(spanner): Add support for Interval feat: Add support for Interval Mar 28, 2025
Comment thread src/codec.ts
Comment thread system-test/spanner.ts
Comment thread system-test/spanner.ts Outdated
Comment thread system-test/spanner.ts
Comment thread test/codec.ts
Comment thread src/codec.ts
Comment thread src/codec.ts
@sagarwaal sagarwaal requested a review from surbhigarg92 April 2, 2025 09:47
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 3, 2025
@surbhigarg92 surbhigarg92 merged commit 8c886cb into googleapis:main Apr 3, 2025
18 checks passed
alkatrivedi pushed a commit that referenced this pull request Apr 14, 2025
* feat(spanner): add support for interval

* skip interval tests only in emulator

* Addressed PR comments

* Added tests for null and undefined values

* fixed lint failure

---------

Co-authored-by: Sagar Agarwal <sagarwaal@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants