Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

feat: add support for UpdateDatabase#1802

Merged
rajatbhatta merged 23 commits intogoogleapis:mainfrom
rajatbhatta:drop-database-protection
May 17, 2023
Merged

feat: add support for UpdateDatabase#1802
rajatbhatta merged 23 commits intogoogleapis:mainfrom
rajatbhatta:drop-database-protection

Conversation

@rajatbhatta
Copy link
Copy Markdown
Contributor

@rajatbhatta rajatbhatta commented Feb 9, 2023 •
edited
Loading

This PR adds code changes, unit tests and integration tests for UpdateDatabase support in Cloud Spanner.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Feb 9, 2023
surbhigarg92
surbhigarg92 reviewed Feb 16, 2023
View reviewed changes
@rajatbhatta rajatbhatta mentioned this pull request Feb 27, 2023
Closed
@rajatbhatta rajatbhatta changed the title feat: add support for drop database protection feat: add support for UpdateDatabase Feb 27, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review May 15, 2023 16:59
@rajatbhatta rajatbhatta requested review from a team May 15, 2023 16:59
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented May 16, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 16, 2023
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented May 16, 2023

Warning: This pull request is touching the following templated files:

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 16, 2023
@rajatbhatta rajatbhatta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 16, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 16, 2023
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green bot commented May 17, 2023

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 17, 2023
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2023
@rajatbhatta rajatbhatta merged commit f4fbe71 into googleapis:main May 17, 2023
@release-please release-please bot mentioned this pull request May 17, 2023
Merged
@21m57 21m57 mentioned this pull request Jul 7, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rajatbhatta @surbhigarg92 @yoshi-kokoro