fix: Begin transaction foes not handle error (#1833)

surbhigarg92 · web-flow · commit 6ecd366da718 · 2023-04-06T13:41:52.000+05:30
diff --git a/src/transaction.ts b/src/transaction.ts
@@ -1774,7 +1774,7 @@ export class Transaction extends Dml {
     } else if (!this._useInRunner) {
       reqOpts.singleUseTransaction = this._options;
     } else {
-      this.begin().then(() => this.commit(options, callback));
+      this.begin().then(() => this.commit(options, callback), callback);
       return;
     }
 
diff --git a/test/spanner.ts b/test/spanner.ts
@@ -3382,6 +3382,30 @@ describe('Spanner with mock server', () => {
       }) as v1.BeginTransactionRequest;
       assert.ok(beginTxnRequest, 'beginTransaction was called');
     });
+
+    it('should throw error if begin transaction fails on blind commit', async () => {
+      const database = newTestDatabase();
+      const err = {
+        message: 'Test error',
+      } as MockError;
+      spannerMock.setExecutionTime(
+        spannerMock.beginTransaction,
+        SimulatedExecutionTime.ofError(err)
+      );
+      try {
+        await database.runTransactionAsync(async tx => {
+          tx.insert('foo', {id: 1, name: 'One'});
+          await tx.commit();
+        });
+      } catch (e) {
+        assert.strictEqual(
+          (e as ServiceError).message,
+          '2 UNKNOWN: Test error'
+        );
+      } finally {
+        await database.close();
+      }
+    });
   });
 
   describe('table', () => {

Original file line number	Diff line number	Diff line change
`@@ -1774,7 +1774,7 @@ export class Transaction extends Dml {`
`1774`	`1774`	`} else if (!this._useInRunner) {`
`1775`	`1775`	`reqOpts.singleUseTransaction = this._options;`
`1776`	`1776`	`} else {`
`1777`		`- this.begin().then(() => this.commit(options, callback));`
	`1777`	`+ this.begin().then(() => this.commit(options, callback), callback);`
`1778`	`1778`	`return;`
`1779`	`1779`	`}`
`1780`	`1780`