Skip to content

fix: use typescript import/export for gapics #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 5 commits into from
May 16, 2019
Merged

fix: use typescript import/export for gapics #611

callmehiphop merged 5 commits into from
May 16, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 16, 2019 •
edited
Loading

Fixes #610

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2019
@callmehiphop callmehiphop mentioned this pull request May 16, 2019
Closed
sduskis
sduskis reviewed May 16, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented May 16, 2019 •
edited
Loading

Codecov Report

Merging #611 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   97.89%   97.89%   +<.01%     
==========================================
  Files          14       14              
  Lines         856      857       +1     
  Branches      178      178              
==========================================
+ Hits          838      839       +1     
  Misses          2        2              
  Partials       16       16
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb26010...e9dd2b3. Read the comment docs.

@callmehiphop callmehiphop merged commit e882e1a into googleapis:master May 16, 2019
@callmehiphop callmehiphop deleted the dg--610 branch May 16, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@sduskis sduskis sduskis left review comments

@bcoe bcoe bcoe approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Property 'PublisherClient' does not exist on type

5 participants

@callmehiphop @sduskis @bcoe @JustinBeckwith @googlebot