Skip to content

feat(subscription): accept pull deadline option #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 4 commits into from
Mar 21, 2019
Merged

feat(subscription): accept pull deadline option #556

callmehiphop merged 4 commits into from
Mar 21, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Mar 20, 2019 •
edited
Loading

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019 •
edited
Loading

Codecov Report

Merging #556 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   94.81%   94.82%   +0.01%     
==========================================
  Files          16       16              
  Lines         965      967       +2     
  Branches       86       86              
==========================================
+ Hits          915      917       +2     
  Misses         42       42              
  Partials        8        8
Impacted Files Coverage Δ
src/message-stream.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed7bfb...ff4e136. Read the comment docs.

@callmehiphop callmehiphop mentioned this pull request Mar 21, 2019
Closed
@slavoroi slavoroi mentioned this pull request Mar 21, 2019
Closed
stephenplusplus
stephenplusplus reviewed Mar 21, 2019
View reviewed changes
@callmehiphop callmehiphop merged commit 468e1bf into googleapis:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @JustinBeckwith @stephenplusplus @googlebot