tests: make another pass at cleaning up flaky tests #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summer-ji-eng
approved these changes
Apr 26, 2022
Contributor
summer-ji-eng
left a comment
There was a problem hiding this comment.
Not enough context on the business, but the typescript syntax and overall test looks good to me.
| let nextTopicId = 0; | ||
| async function createTopic(): Promise<Topic> { | ||
| const id = `${topicNameStem}-${nextTopicId++}`; | ||
| console.log(`Subscriptions runId: ${runId}`); |
Contributor
There was a problem hiding this comment.
Is this console.log intention?
Collaborator
Author
There was a problem hiding this comment.
Yep! It's for debug purposes in case there are test failures or leftover topics. (We do it in several of the test suites, so should be okay here.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests were still being flaky. This should be a big enough hammer to fix it, hopefully.
Larger explanation: some earlier changes I made to make the cleanup of tests more deterministic actually ended up making them flaky. This change wraps each test with its own cleanup that looks for items specifically for that test, so the tests won't interrupt each other when running concurrently.
Fixes #1498 🦕