-
Notifications
You must be signed in to change notification settings - Fork 235
Closed
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.Issues related to the googleapis/nodejs-pubsub API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
An earlier change made the message queues continue trying to send messages until the queues are empty (so that drain works). However, because of async code, it's possible that more messages might legitimately fill in that we don't want to send immediately (batching instead of flush). This was caused by:
The visible symptom is that you can set a max number of messages in a batch with a long max timeout, and then do async publishMessage() for more than the max number of messages, but all of them will basically send at once, instead of waiting for the timeout for the second batch. (bug 270113896)
Metadata
Metadata
Assignees
Labels
api: pubsubIssues related to the googleapis/nodejs-pubsub API.Issues related to the googleapis/nodejs-pubsub API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.