Skip to content

fix: fix flaky schema and subscription tests #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feywind merged 5 commits into from
Apr 19, 2022
Merged

fix: fix flaky schema and subscription tests #1518

feywind merged 5 commits into from
Apr 19, 2022

Conversation

@feywind
Copy link
Collaborator

@feywind feywind commented Apr 13, 2022

Potential fixes:

#1498
#1516
#1468
#1327

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 13, 2022
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind
Copy link
Collaborator Author

feywind commented Apr 13, 2022

I'm going to run this through CI a few more times just to make sure it's not flaking now...

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind marked this pull request as ready for review April 13, 2022 19:04
@feywind feywind requested review from a team as code owners April 13, 2022 19:04
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind changed the title tests: fix flaky schema and subscription tests fix: fix flaky schema and subscription tests Apr 13, 2022
@feywind
Copy link
Collaborator Author

feywind commented Apr 13, 2022

I'm editing the type to fix to trigger another release, since apparently the last one failed?

@feywind
Copy link
Collaborator Author

feywind commented Apr 14, 2022

Mentioned in chat, but repeating here: if anyone reviews this and there aren't major issues, please go ahead and merge as well.

@feywind feywind merged commit 5ff0105 into googleapis:main Apr 19, 2022
@feywind feywind deleted the flaky-tests branch April 19, 2022 17:25
@release-please release-please bot mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feywind @alexander-fenster @yoshi-kokoro