fix: update grpc.max_metadata_size to 4MiB for exactly-once, and shift ack/modack errors to 'debug' stream channel #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradn
reviewed
Mar 21, 2022
pradn
left a comment
There was a problem hiding this comment.
Looks good. Please test:
- subscribing for a long time from a exactly-once delivery-enabled subscription
- subscribing from a regular subscription and turning on exactly-once for the subscription
In both cases, the subscribing should continue as normal.
Collaborator
Author
These are tested and pass after the fix for the ack/modack errors. |
bcoe
approved these changes
Apr 5, 2022
bcoe
left a comment
There was a problem hiding this comment.
Left one nit that might be worth fixing.
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this sets a default value for
grpc.max_metadata_size.While fixing that, I discovered that we are incorrectly raising a client error for ack/modack failures. Rather than making these go silent for users (for debug purposes), I moved them to a 'debug' channel that can also be subscribed on Subscription instances.
Fixes #1504 🦕