Skip to content

fix(deps): update dependency @google-cloud/common to ^0.23.0 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhinkel merged 2 commits into from
Sep 5, 2018
Merged

fix(deps): update dependency @google-cloud/common to ^0.23.0 #152

fhinkel merged 2 commits into from
Sep 5, 2018

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Aug 29, 2018

Move common to devDependencies. It is only used in
errors-transport.ts system tests.

Fixes: #151

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2018
@ghost ghost assigned fhinkel Aug 29, 2018
@fhinkel fhinkel requested a review from DominicKramer August 29, 2018 13:06
@fhinkel fhinkel mentioned this pull request Aug 29, 2018
Merged
@fhinkel
Copy link
Contributor Author

fhinkel commented Aug 29, 2018 •
edited
Loading

Are we using some older grpc-logging and therefore common-grpc? I'm not quite sure I understand how this passes in 8 and 10 but not in 6:

TypeError: common_1.util.promisifyAll is not a function
    at Object.<anonymous> (/usr/local/google/home/franzih/code/gcp/nodejs-logging-winston/node_modules/@google-cloud/common-grpc/src/service-object.ts:124:6)
    at Module._compile (module.js:577:32)
    at Module._extensions..js (module.js:586:10)
    at Object.extensions..js (/usr/local/google/home/franzih/code/gcp/nodejs-logging-winston/node_modules/espower-loader/index.js:47:13)

@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Aug 29, 2018

It's possible we haven't shipped nodejs-common-grpc in a while

@fhinkel
fix(deps): update dependency @google-cloud/common to ^0.23.0 and logg…
388024e 
…ing.

Update @google-cloud/logging@ to 3.0.2.

Move common to devDependencies. It is only used in
errors-transport system tests.

Fixes: #151
@fhinkel fhinkel requested a review from JustinBeckwith August 29, 2018 20:32
@fhinkel
Copy link
Contributor Author

fhinkel commented Aug 29, 2018

OK, passes with new logging. Ready for review

@DominicKramer DominicKramer mentioned this pull request Aug 29, 2018
Closed
@fhinkel fhinkel merged commit 35b5fd2 into master Sep 5, 2018
@fhinkel fhinkel deleted the updateCommon branch September 5, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DominicKramer DominicKramer Awaiting requested review from DominicKramer

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fhinkel fhinkel

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhinkel @JustinBeckwith @googlebot